patrick/OpenDTU-old
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix: Lint Error: Almost always, snprintf is better than strcpy

Browse Source
This commit is contained in:
Thomas Basler 2023-06-01 23:30:13 +02:00
parent 5558dffa70
commit 7f267ff2fb
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/WebApi_ntp.cpp
View File

@ -55,14 +55,14 @@ void WebApiNtpClass::onNtpStatus(AsyncWebServerRequest* request)
if (SunPosition.sunriseTime(&timeinfo)) { if (SunPosition.sunriseTime(&timeinfo)) {
strftime(timeStringBuff, sizeof(timeStringBuff), "%A, %B %d %Y %H:%M:%S", &timeinfo); strftime(timeStringBuff, sizeof(timeStringBuff), "%A, %B %d %Y %H:%M:%S", &timeinfo);
} else { } else {
strcpy(timeStringBuff, "--"); snprintf(timeStringBuff, sizeof(timeStringBuff), "--");
} }
root["sun_risetime"] = timeStringBuff; root["sun_risetime"] = timeStringBuff;
if (SunPosition.sunsetTime(&timeinfo)) { if (SunPosition.sunsetTime(&timeinfo)) {
strftime(timeStringBuff, sizeof(timeStringBuff), "%A, %B %d %Y %H:%M:%S", &timeinfo); strftime(timeStringBuff, sizeof(timeStringBuff), "%A, %B %d %Y %H:%M:%S", &timeinfo);
} else { } else {
strcpy(timeStringBuff, "--"); snprintf(timeStringBuff, sizeof(timeStringBuff), "--");
} }
root["sun_settime"] = timeStringBuff; root["sun_settime"] = timeStringBuff;