From 7f267ff2fb7c06815a6c28ac00745d4cbd9ed9eb Mon Sep 17 00:00:00 2001 From: Thomas Basler Date: Thu, 1 Jun 2023 23:30:13 +0200 Subject: [PATCH] Fix: Lint Error: Almost always, snprintf is better than strcpy --- src/WebApi_ntp.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/WebApi_ntp.cpp b/src/WebApi_ntp.cpp index 26524c2a..67b30851 100644 --- a/src/WebApi_ntp.cpp +++ b/src/WebApi_ntp.cpp @@ -55,14 +55,14 @@ void WebApiNtpClass::onNtpStatus(AsyncWebServerRequest* request) if (SunPosition.sunriseTime(&timeinfo)) { strftime(timeStringBuff, sizeof(timeStringBuff), "%A, %B %d %Y %H:%M:%S", &timeinfo); } else { - strcpy(timeStringBuff, "--"); + snprintf(timeStringBuff, sizeof(timeStringBuff), "--"); } root["sun_risetime"] = timeStringBuff; if (SunPosition.sunsetTime(&timeinfo)) { strftime(timeStringBuff, sizeof(timeStringBuff), "%A, %B %d %Y %H:%M:%S", &timeinfo); } else { - strcpy(timeStringBuff, "--"); + snprintf(timeStringBuff, sizeof(timeStringBuff), "--"); } root["sun_settime"] = timeStringBuff;