patrick/OpenDTU-old
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Removed checking for valid tx pin for Victron (#455)

Browse Source 
Please check wiki documentation, and change/extend it accordingly.
This commit is contained in:
Philipp Sandhaus 2023-09-28 13:13:32 +02:00 committed by GitHub
parent 933345d659
commit 4ee49a6ecb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/PinMapping.cpp
View File

@ -307,8 +307,7 @@ bool PinMappingClass::isValidEthConfig()
bool PinMappingClass::isValidVictronConfig() bool PinMappingClass::isValidVictronConfig()
{ {
return _pinMapping.victron_rx >= 0 return _pinMapping.victron_rx >= 0;
&& _pinMapping.victron_tx >= 0;
} }
bool PinMappingClass::isValidHuaweiConfig() bool PinMappingClass::isValidHuaweiConfig()

2
src/VictronSmartShunt.cpp
View File

@ -13,7 +13,7 @@ bool VictronSmartShunt::init(bool verboseLogging)
MessageOutput.printf("[VictronSmartShunt] Interface rx = %d, tx = %d\r\n", MessageOutput.printf("[VictronSmartShunt] Interface rx = %d, tx = %d\r\n",
pin.battery_rx, pin.battery_tx); pin.battery_rx, pin.battery_tx);
if (pin.battery_rx < 0 || pin.battery_tx < 0) { if (pin.battery_rx < 0) {
MessageOutput.println(F("[VictronSmartShunt] Invalid pin config")); MessageOutput.println(F("[VictronSmartShunt] Invalid pin config"));
return false; return false;
} }