From 4ee49a6ecb90a800e57db7554a88b53cb0bf55af Mon Sep 17 00:00:00 2001 From: Philipp Sandhaus Date: Thu, 28 Sep 2023 13:13:32 +0200 Subject: [PATCH] Removed checking for valid tx pin for Victron (#455) Please check wiki documentation, and change/extend it accordingly. --- src/PinMapping.cpp | 3 +-- src/VictronSmartShunt.cpp | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/PinMapping.cpp b/src/PinMapping.cpp index 31cb0f58..b680edb3 100644 --- a/src/PinMapping.cpp +++ b/src/PinMapping.cpp @@ -307,8 +307,7 @@ bool PinMappingClass::isValidEthConfig() bool PinMappingClass::isValidVictronConfig() { - return _pinMapping.victron_rx >= 0 - && _pinMapping.victron_tx >= 0; + return _pinMapping.victron_rx >= 0; } bool PinMappingClass::isValidHuaweiConfig() diff --git a/src/VictronSmartShunt.cpp b/src/VictronSmartShunt.cpp index 052f7abd..30e75545 100644 --- a/src/VictronSmartShunt.cpp +++ b/src/VictronSmartShunt.cpp @@ -13,7 +13,7 @@ bool VictronSmartShunt::init(bool verboseLogging) MessageOutput.printf("[VictronSmartShunt] Interface rx = %d, tx = %d\r\n", pin.battery_rx, pin.battery_tx); - if (pin.battery_rx < 0 || pin.battery_tx < 0) { + if (pin.battery_rx < 0) { MessageOutput.println(F("[VictronSmartShunt] Invalid pin config")); return false; }