From 2b80b1d6715bafb8ec5edbd319cbd031a162e4eb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Patrick=20Ha=C3=9Fel?= Date: Mon, 27 Jan 2025 14:47:37 +0100 Subject: [PATCH] setBrightness safe handling + return --- src/demo/NodeTest.h | 3 +-- src/patrix/display/Display.h | 11 ++++++----- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/demo/NodeTest.h b/src/demo/NodeTest.h index caa7f21..f84656e 100644 --- a/src/demo/NodeTest.h +++ b/src/demo/NodeTest.h @@ -19,8 +19,7 @@ public: void setup() override { config.read(); - display.setup(); - display.setBrightness(6); + display.setup(10); display.clear(); display.printf(1, 1, LEFT, Blue, "Test"); display.drawLine(0, 7, 32, 0, 1, Red); diff --git a/src/patrix/display/Display.h b/src/patrix/display/Display.h index e4dc305..079f786 100644 --- a/src/patrix/display/Display.h +++ b/src/patrix/display/Display.h @@ -58,9 +58,9 @@ public: // basic ---------------------------------------------------------------------------------------- - void setup() { + void setup(const int brightness) { leds.begin(); - leds.setBrightness(10); + setBrightness(brightness); clear(); } @@ -78,11 +78,13 @@ public: } } - void setBrightness(const uint8_t brightness) { + uint8_t setBrightness(int brightness) { + brightness = max(0, min(brightness, 255)); if (leds.getBrightness() != brightness) { leds.setBrightness(brightness); dirty = true; } + return brightness; } uint8_t getBrightness() const { @@ -176,8 +178,7 @@ public: } else if (align == CENTER) { x = x - w / 2; } - } else { - } + } else {} } void measure(const char *message, int& w, int& h) {