From 98b0a23ea08e2edddc19a7b17f238c22690ae644 Mon Sep 17 00:00:00 2001
From: Thomas Basler <thomas@familie-basler.net>
Date: Fri, 23 Dec 2022 17:54:27 +0100
Subject: [PATCH] Introduce numeric error codes in config webapi

---
 include/WebApi_errors.h | 4 ++++
 src/WebApi_config.cpp   | 7 +++++++
 2 files changed, 11 insertions(+)

diff --git a/include/WebApi_errors.h b/include/WebApi_errors.h
index e5b854f..05fe52b 100644
--- a/include/WebApi_errors.h
+++ b/include/WebApi_errors.h
@@ -13,4 +13,8 @@ enum WebApiError {
     DtuSerialZero,
     DtuPollZero,
     DtuInvalidPowerLevel,
+
+    ConfigBase = 3000,
+    ConfigNotDeleted,
+    ConfigSuccess
 };
\ No newline at end of file
diff --git a/src/WebApi_config.cpp b/src/WebApi_config.cpp
index c848b36..bd08745 100644
--- a/src/WebApi_config.cpp
+++ b/src/WebApi_config.cpp
@@ -5,6 +5,7 @@
 #include "WebApi_config.h"
 #include "Configuration.h"
 #include "WebApi.h"
+#include "WebApi_errors.h"
 #include <AsyncJson.h>
 #include <LittleFS.h>
 
@@ -51,6 +52,7 @@ void WebApiConfigClass::onConfigDelete(AsyncWebServerRequest* request)
 
     if (!request->hasParam("data", true)) {
         retMsg[F("message")] = F("No values found!");
+        retMsg[F("code")] = WebApiError::GenericNoValueFound;
         response->setLength();
         request->send(response);
         return;
@@ -60,6 +62,7 @@ void WebApiConfigClass::onConfigDelete(AsyncWebServerRequest* request)
 
     if (json.length() > 1024) {
         retMsg[F("message")] = F("Data too large!");
+        retMsg[F("code")] = WebApiError::GenericDataTooLarge;
         response->setLength();
         request->send(response);
         return;
@@ -70,6 +73,7 @@ void WebApiConfigClass::onConfigDelete(AsyncWebServerRequest* request)
 
     if (error) {
         retMsg[F("message")] = F("Failed to parse data!");
+        retMsg[F("code")] = WebApiError::GenericDataTooLarge;
         response->setLength();
         request->send(response);
         return;
@@ -77,6 +81,7 @@ void WebApiConfigClass::onConfigDelete(AsyncWebServerRequest* request)
 
     if (!(root.containsKey("delete"))) {
         retMsg[F("message")] = F("Values are missing!");
+        retMsg[F("code")] = WebApiError::GenericValueMissing;
         response->setLength();
         request->send(response);
         return;
@@ -84,6 +89,7 @@ void WebApiConfigClass::onConfigDelete(AsyncWebServerRequest* request)
 
     if (root[F("delete")].as<bool>() == false) {
         retMsg[F("message")] = F("Not deleted anything!");
+        retMsg[F("code")] = WebApiError::ConfigNotDeleted;
         response->setLength();
         request->send(response);
         return;
@@ -91,6 +97,7 @@ void WebApiConfigClass::onConfigDelete(AsyncWebServerRequest* request)
 
     retMsg[F("type")] = F("success");
     retMsg[F("message")] = F("Configuration resettet. Rebooting now...");
+    retMsg[F("code")] = WebApiError::ConfigSuccess;
 
     response->setLength();
     request->send(response);