BREAKING CHANGE: Web API Endpoint /api/devinfo/status requires GET parameter inv=

Only the requested inverter is sent to the client. This reduces the size of the json response --> Less memory.

It should also fix #814.
This commit is contained in:
Thomas Basler 2023-04-17 21:48:16 +02:00
parent af3a277e30
commit 59f43a82a8
2 changed files with 18 additions and 13 deletions

View File

@ -30,22 +30,27 @@ void WebApiDevInfoClass::onDevInfoStatus(AsyncWebServerRequest* request)
AsyncJsonResponse* response = new AsyncJsonResponse(); AsyncJsonResponse* response = new AsyncJsonResponse();
JsonObject root = response->getRoot(); JsonObject root = response->getRoot();
for (uint8_t i = 0; i < Hoymiles.getNumInverters(); i++) { uint64_t serial = 0;
auto inv = Hoymiles.getInverterByPos(i); if (request->hasParam("inv")) {
String s = request->getParam("inv")->value();
serial = strtoll(s.c_str(), NULL, 16);
}
JsonObject devInfoObj = root[inv->serialString()].createNestedObject(); auto inv = Hoymiles.getInverterBySerial(serial);
devInfoObj["valid_data"] = inv->DevInfo()->getLastUpdate() > 0;
devInfoObj["fw_bootloader_version"] = inv->DevInfo()->getFwBootloaderVersion(); if (inv != nullptr) {
devInfoObj["fw_build_version"] = inv->DevInfo()->getFwBuildVersion(); root["valid_data"] = inv->DevInfo()->getLastUpdate() > 0;
devInfoObj["hw_part_number"] = inv->DevInfo()->getHwPartNumber(); root["fw_bootloader_version"] = inv->DevInfo()->getFwBootloaderVersion();
devInfoObj["hw_version"] = inv->DevInfo()->getHwVersion(); root["fw_build_version"] = inv->DevInfo()->getFwBuildVersion();
devInfoObj["hw_model_name"] = inv->DevInfo()->getHwModelName(); root["hw_part_number"] = inv->DevInfo()->getHwPartNumber();
devInfoObj["max_power"] = inv->DevInfo()->getMaxPower(); root["hw_version"] = inv->DevInfo()->getHwVersion();
root["hw_model_name"] = inv->DevInfo()->getHwModelName();
root["max_power"] = inv->DevInfo()->getMaxPower();
char timebuffer[32]; char timebuffer[32];
const time_t t = inv->DevInfo()->getFwBuildDateTime(); const time_t t = inv->DevInfo()->getFwBuildDateTime();
std::strftime(timebuffer, sizeof(timebuffer), "%Y-%m-%d %H:%M:%S", gmtime(&t)); std::strftime(timebuffer, sizeof(timebuffer), "%Y-%m-%d %H:%M:%S", gmtime(&t));
devInfoObj["fw_build_datetime"] = String(timebuffer); root["fw_build_datetime"] = String(timebuffer);
} }
response->setLength(); response->setLength();

View File

@ -544,10 +544,10 @@ export default defineComponent({
}, },
onShowDevInfo(serial: number) { onShowDevInfo(serial: number) {
this.devInfoLoading = true; this.devInfoLoading = true;
fetch("/api/devinfo/status", { headers: authHeader() }) fetch("/api/devinfo/status?inv=" + serial, { headers: authHeader() })
.then((response) => handleResponse(response, this.$emitter, this.$router)) .then((response) => handleResponse(response, this.$emitter, this.$router))
.then((data) => { .then((data) => {
this.devInfoList = data[serial][0]; this.devInfoList = data;
this.devInfoList.serial = serial; this.devInfoList.serial = serial;
this.devInfoLoading = false; this.devInfoLoading = false;
}); });