Feature: support 'use battery at night' without VE.Direct

previously, we needed VE.Direct enabled to know the
solar charge controller output, which solely decided when
it was "nighttime". since this is now determined by the
wall clock, we can offer this feature to users without a
Victron charge controller connected using VE.Direct.

src/PowerLimiter.cpp

@@ -251,8 +251,7 @@ void PowerLimiterClass::loop()
 
         if (isStartThresholdReached()) { return true; }
 
-        if (config.PowerLimiter.SolarPassThroughEnabled &&
+        if (config.PowerLimiter.BatteryAlwaysUseAtNight &&
-                config.PowerLimiter.BatteryAlwaysUseAtNight &&
                 !isDayPeriod &&
                 !_batteryDischargeEnabled) {
             _nighttimeDischarging = true;

src/WebApi_powerlimiter.cpp

@@ -153,13 +153,13 @@ void WebApiPowerLimiterClass::onAdminPost(AsyncWebServerRequest* request)
     if (config.Vedirect.Enabled) {
         config.PowerLimiter.SolarPassThroughEnabled = root["solar_passthrough_enabled"].as<bool>();
         config.PowerLimiter.SolarPassThroughLosses = root["solar_passthrough_losses"].as<uint8_t>();
-        config.PowerLimiter.BatteryAlwaysUseAtNight= root["battery_always_use_at_night"].as<bool>();
         config.PowerLimiter.FullSolarPassThroughStartVoltage = static_cast<int>(root["full_solar_passthrough_start_voltage"].as<float>() * 100) / 100.0;
         config.PowerLimiter.FullSolarPassThroughStopVoltage = static_cast<int>(root["full_solar_passthrough_stop_voltage"].as<float>() * 100) / 100.0;
     }
 
     config.PowerLimiter.IsInverterBehindPowerMeter = root["is_inverter_behind_powermeter"].as<bool>();
     config.PowerLimiter.IsInverterSolarPowered = root["is_inverter_solar_powered"].as<bool>();
+    config.PowerLimiter.BatteryAlwaysUseAtNight = root["battery_always_use_at_night"].as<bool>();
     config.PowerLimiter.UseOverscalingToCompensateShading = root["use_overscaling_to_compensate_shading"].as<bool>();
     config.PowerLimiter.InverterId = root["inverter_serial"].as<uint64_t>();
     config.PowerLimiter.InverterChannelId = root["inverter_channel_id"].as<uint8_t>();

webapp/src/views/PowerLimiterAdminView.vue

@@ -105,6 +105,14 @@
                     wide
                 />
 
+                <InputElement
+                    v-show="canUseBatteryDischargeAtNight()"
+                    :label="$t('powerlimiteradmin.BatteryDischargeAtNight')"
+                    v-model="powerLimiterConfigList.battery_always_use_at_night"
+                    type="checkbox"
+                    wide
+                />
+
                 <InputElement
                     v-show="canUseOverscaling()"
                     :label="$t('powerlimiteradmin.UseOverscalingToCompensateShading')"
@@ -221,13 +229,6 @@
                 />
 
                 <div v-if="powerLimiterConfigList.solar_passthrough_enabled">
-                    <InputElement
-                        :label="$t('powerlimiteradmin.BatteryDischargeAtNight')"
-                        v-model="powerLimiterConfigList.battery_always_use_at_night"
-                        type="checkbox"
-                        wide
-                    />
-
                     <InputElement
                         :label="$t('powerlimiteradmin.SolarPassthroughLosses')"
                         v-model="powerLimiterConfigList.solar_passthrough_losses"
@@ -493,6 +494,10 @@ export default defineComponent({
             const cfg = this.powerLimiterConfigList;
             return cfg.is_inverter_solar_powered;
         },
+        canUseBatteryDischargeAtNight() {
+            const cfg = this.powerLimiterConfigList;
+            return !cfg.is_inverter_solar_powered;
+        },
         canUseSolarPassthrough() {
             const cfg = this.powerLimiterConfigList;
             const meta = this.powerLimiterMetaData;