patrick/OpenDTU-old
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix: SBS Unipower battery discharge current handling

Browse Source 
SBS CAN receiver implementation was not using the correct way to provide
discharge current limit.
This commit is contained in:
Andreas Böhm 2024-10-23 21:47:50 +02:00 committed by Bernhard Kirchen
parent 17016b179f
commit d36b30ae0e
3 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
include/BatteryStats.h
View File

@ -159,7 +159,6 @@ class SBSBatteryStats : public BatteryStats {
float _chargeVoltage; float _chargeVoltage;
float _chargeCurrentLimitation; float _chargeCurrentLimitation;
float _dischargeCurrentLimitation;
uint16_t _stateOfHealth; uint16_t _stateOfHealth;
float _current; float _current;
float _temperature; float _temperature;

2
src/BatteryStats.cpp
View File

@ -163,7 +163,6 @@ void SBSBatteryStats::getLiveViewData(JsonVariant& root) const
// values go into the "Status" card of the web application // values go into the "Status" card of the web application
addLiveViewValue(root, "chargeVoltage", _chargeVoltage, "V", 1); addLiveViewValue(root, "chargeVoltage", _chargeVoltage, "V", 1);
addLiveViewValue(root, "chargeCurrentLimitation", _chargeCurrentLimitation, "A", 1); addLiveViewValue(root, "chargeCurrentLimitation", _chargeCurrentLimitation, "A", 1);
addLiveViewValue(root, "dischargeCurrentLimitation", _dischargeCurrentLimitation, "A", 1);
addLiveViewValue(root, "stateOfHealth", _stateOfHealth, "%", 0); addLiveViewValue(root, "stateOfHealth", _stateOfHealth, "%", 0);
addLiveViewValue(root, "current", _current, "A", 1); addLiveViewValue(root, "current", _current, "A", 1);
addLiveViewValue(root, "temperature", _temperature, "°C", 1); addLiveViewValue(root, "temperature", _temperature, "°C", 1);
@ -419,7 +418,6 @@ void SBSBatteryStats::mqttPublish() const
MqttSettings.publish("battery/settings/chargeVoltage", String(_chargeVoltage)); MqttSettings.publish("battery/settings/chargeVoltage", String(_chargeVoltage));
MqttSettings.publish("battery/settings/chargeCurrentLimitation", String(_chargeCurrentLimitation)); MqttSettings.publish("battery/settings/chargeCurrentLimitation", String(_chargeCurrentLimitation));
MqttSettings.publish("battery/settings/dischargeCurrentLimitation", String(_dischargeCurrentLimitation));
MqttSettings.publish("battery/stateOfHealth", String(_stateOfHealth)); MqttSettings.publish("battery/stateOfHealth", String(_stateOfHealth));
MqttSettings.publish("battery/current", String(_current)); MqttSettings.publish("battery/current", String(_current));
MqttSettings.publish("battery/temperature", String(_temperature)); MqttSettings.publish("battery/temperature", String(_temperature));

6
src/SBSCanReceiver.cpp
View File

@ -74,10 +74,10 @@ void SBSCanReceiver::onMessage(twai_message_t rx_message)
case 0x640: { case 0x640: {
_stats->_chargeCurrentLimitation = (this->readSignedInt24(rx_message.data + 3) * 0.001); _stats->_chargeCurrentLimitation = (this->readSignedInt24(rx_message.data + 3) * 0.001);
_stats->_dischargeCurrentLimitation = (this->readSignedInt24(rx_message.data)) * 0.001; _stats->setDischargeCurrentLimit(this->readSignedInt24(rx_message.data) * 0.001, millis());
if (_verboseLogging) { if (_verboseLogging) {
MessageOutput.printf("[SBS Unipower] 1600 Currents %f, %f \r\n", _stats->_chargeCurrentLimitation, _stats->_dischargeCurrentLimitation); MessageOutput.printf("[SBS Unipower] 1600 Currents %f, %f \r\n", _stats->_chargeCurrentLimitation, _stats->getDischargeCurrentLimit());
} }
break; break;
} }
@ -144,7 +144,7 @@ void SBSCanReceiver::dummyData()
_stats->setSoC(42, 0/*precision*/, millis()); _stats->setSoC(42, 0/*precision*/, millis());
_stats->_chargeVoltage = dummyFloat(50); _stats->_chargeVoltage = dummyFloat(50);
_stats->_chargeCurrentLimitation = dummyFloat(33); _stats->_chargeCurrentLimitation = dummyFloat(33);
_stats->_dischargeCurrentLimitation = dummyFloat(12); _stats->setDischargeCurrentLimit(dummyFloat(12), millis());
_stats->_stateOfHealth = 99; _stats->_stateOfHealth = 99;
_stats->setVoltage(48.67, millis()); _stats->setVoltage(48.67, millis());
_stats->_current = dummyFloat(-1); _stats->_current = dummyFloat(-1);