From c999197dae3b1036f861a80dbbf980fb3cae2351 Mon Sep 17 00:00:00 2001
From: Thomas Basler <thomas@familie-basler.net>
Date: Fri, 28 Oct 2022 23:27:59 +0200
Subject: [PATCH] Optimize performance by passing strings as const reference

---
 include/MqttSettings.h | 4 ++--
 src/MqttSettings.cpp   | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/include/MqttSettings.h b/include/MqttSettings.h
index 209a8ad6..afa3283c 100644
--- a/include/MqttSettings.h
+++ b/include/MqttSettings.h
@@ -13,8 +13,8 @@ public:
     void init();
     void performReconnect();
     bool getConnected();
-    void publish(String subtopic, String payload);
-    void publishHass(String subtopic, String payload);
+    void publish(const String& subtopic, const String& payload);
+    void publishHass(const String& subtopic, const String& payload);
 
     String getPrefix();
 
diff --git a/src/MqttSettings.cpp b/src/MqttSettings.cpp
index d7e7a655..516409bd 100644
--- a/src/MqttSettings.cpp
+++ b/src/MqttSettings.cpp
@@ -233,14 +233,14 @@ String MqttSettingsClass::getPrefix()
     return Configuration.get().Mqtt_Topic;
 }
 
-void MqttSettingsClass::publish(String subtopic, String payload)
+void MqttSettingsClass::publish(const String& subtopic, const String& payload)
 {
     String topic = getPrefix();
     topic += subtopic;
     mqttClient->publish(topic.c_str(), 0, Configuration.get().Mqtt_Retain, payload.c_str());
 }
 
-void MqttSettingsClass::publishHass(String subtopic, String payload)
+void MqttSettingsClass::publishHass(const String& subtopic, const String& payload)
 {
     String topic = Configuration.get().Mqtt_Hass_Topic;
     topic += subtopic;