patrick/OpenDTU-old
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Introduce numeric error codes in config webapi

Browse Source
This commit is contained in:
Thomas Basler 2022-12-23 17:54:27 +01:00
parent 68d8c13b8e
commit 98b0a23ea0
2 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
include/WebApi_errors.h
View File

@ -13,4 +13,8 @@ enum WebApiError {
DtuSerialZero, DtuSerialZero,
DtuPollZero, DtuPollZero,
DtuInvalidPowerLevel, DtuInvalidPowerLevel,
ConfigBase = 3000,
ConfigNotDeleted,
ConfigSuccess
}; };

7
src/WebApi_config.cpp
View File

@ -5,6 +5,7 @@
#include "WebApi_config.h" #include "WebApi_config.h"
#include "Configuration.h" #include "Configuration.h"
#include "WebApi.h" #include "WebApi.h"
#include "WebApi_errors.h"
#include <AsyncJson.h> #include <AsyncJson.h>
#include <LittleFS.h> #include <LittleFS.h>
@ -51,6 +52,7 @@ void WebApiConfigClass::onConfigDelete(AsyncWebServerRequest* request)
if (!request->hasParam("data", true)) { if (!request->hasParam("data", true)) {
retMsg[F("message")] = F("No values found!"); retMsg[F("message")] = F("No values found!");
retMsg[F("code")] = WebApiError::GenericNoValueFound;
response->setLength(); response->setLength();
request->send(response); request->send(response);
return; return;
@ -60,6 +62,7 @@ void WebApiConfigClass::onConfigDelete(AsyncWebServerRequest* request)
if (json.length() > 1024) { if (json.length() > 1024) {
retMsg[F("message")] = F("Data too large!"); retMsg[F("message")] = F("Data too large!");
retMsg[F("code")] = WebApiError::GenericDataTooLarge;
response->setLength(); response->setLength();
request->send(response); request->send(response);
return; return;
@ -70,6 +73,7 @@ void WebApiConfigClass::onConfigDelete(AsyncWebServerRequest* request)
if (error) { if (error) {
retMsg[F("message")] = F("Failed to parse data!"); retMsg[F("message")] = F("Failed to parse data!");
retMsg[F("code")] = WebApiError::GenericDataTooLarge;
response->setLength(); response->setLength();
request->send(response); request->send(response);
return; return;
@ -77,6 +81,7 @@ void WebApiConfigClass::onConfigDelete(AsyncWebServerRequest* request)
if (!(root.containsKey("delete"))) { if (!(root.containsKey("delete"))) {
retMsg[F("message")] = F("Values are missing!"); retMsg[F("message")] = F("Values are missing!");
retMsg[F("code")] = WebApiError::GenericValueMissing;
response->setLength(); response->setLength();
request->send(response); request->send(response);
return; return;
@ -84,6 +89,7 @@ void WebApiConfigClass::onConfigDelete(AsyncWebServerRequest* request)
if (root[F("delete")].as<bool>() == false) { if (root[F("delete")].as<bool>() == false) {
retMsg[F("message")] = F("Not deleted anything!"); retMsg[F("message")] = F("Not deleted anything!");
retMsg[F("code")] = WebApiError::ConfigNotDeleted;
response->setLength(); response->setLength();
request->send(response); request->send(response);
return; return;
@ -91,6 +97,7 @@ void WebApiConfigClass::onConfigDelete(AsyncWebServerRequest* request)
retMsg[F("type")] = F("success"); retMsg[F("type")] = F("success");
retMsg[F("message")] = F("Configuration resettet. Rebooting now..."); retMsg[F("message")] = F("Configuration resettet. Rebooting now...");
retMsg[F("code")] = WebApiError::ConfigSuccess;
response->setLength(); response->setLength();
request->send(response); request->send(response);