patrick/OpenDTU-old
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

SML parser: remove commented-out code

Browse Source 
the comparison is part of the original library code, but the compiler
rightfully complains that the comparison byte <= 0xFF is always true,
since byte is uint8_t. the comparison was commented out, and is now
removed.
This commit is contained in:
Bernhard Kirchen 2024-06-14 22:58:33 +02:00
parent 1afa9a6d90
commit 7f724ce561
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/SMLParser/sml.cpp
View File

@ -171,7 +171,7 @@ void checkMagicByte(unsigned char &byte)
// Datatype Octet String // Datatype Octet String
setState(SML_HDATA, (byte & 0x0F) << 4); setState(SML_HDATA, (byte & 0x0F) << 4);
} }
else if (byte >= 0xF0 /*&& byte <= 0xFF*/) { else if (byte >= 0xF0) {
/* Datatype List of ...*/ /* Datatype List of ...*/
setState(SML_LISTEXTENDED, (byte & 0x0F) << 4); setState(SML_LISTEXTENDED, (byte & 0x0F) << 4);
} }