From 7f724ce561f4f48dad344d100d55e7e01117a3e9 Mon Sep 17 00:00:00 2001 From: Bernhard Kirchen Date: Fri, 14 Jun 2024 22:58:33 +0200 Subject: [PATCH] SML parser: remove commented-out code the comparison is part of the original library code, but the compiler rightfully complains that the comparison byte <= 0xFF is always true, since byte is uint8_t. the comparison was commented out, and is now removed. --- lib/SMLParser/sml.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/SMLParser/sml.cpp b/lib/SMLParser/sml.cpp index fbe1efc9..c4335c44 100644 --- a/lib/SMLParser/sml.cpp +++ b/lib/SMLParser/sml.cpp @@ -171,7 +171,7 @@ void checkMagicByte(unsigned char &byte) // Datatype Octet String setState(SML_HDATA, (byte & 0x0F) << 4); } - else if (byte >= 0xF0 /*&& byte <= 0xFF*/) { + else if (byte >= 0xF0) { /* Datatype List of ...*/ setState(SML_LISTEXTENDED, (byte & 0x0F) << 4); }