patrick/OpenDTU-old
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Simplify inverterEdit method

Browse Source 
Replaced for loop with unused variable by .size() method
This commit is contained in:
Thomas Basler 2022-10-05 18:37:34 +02:00
parent 9c4076d3d5
commit 112664f42f
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/WebApi_inverter.cpp
View File

@ -210,11 +210,7 @@ void WebApiInverterClass::onInverterEdit(AsyncWebServerRequest* request)
} }
JsonArray maxPowerArray = root[F("max_power")].as<JsonArray>(); JsonArray maxPowerArray = root[F("max_power")].as<JsonArray>();
uint8_t arrayCount = 0; if (maxPowerArray.size() != INV_MAX_CHAN_COUNT) {
for (JsonVariant maxPower : maxPowerArray) {
arrayCount++;
}
if (arrayCount != INV_MAX_CHAN_COUNT) {
retMsg[F("message")] = F("Invalid amount of max channel setting given!"); retMsg[F("message")] = F("Invalid amount of max channel setting given!");
response->setLength(); response->setLength();
request->send(response); request->send(response);
@ -230,7 +226,7 @@ void WebApiInverterClass::onInverterEdit(AsyncWebServerRequest* request)
inverter.Serial = new_serial; inverter.Serial = new_serial;
strncpy(inverter.Name, root[F("name")].as<String>().c_str(), INV_MAX_NAME_STRLEN); strncpy(inverter.Name, root[F("name")].as<String>().c_str(), INV_MAX_NAME_STRLEN);
arrayCount = 0; uint8_t arrayCount = 0;
for (JsonVariant maxPower : maxPowerArray) { for (JsonVariant maxPower : maxPowerArray) {
inverter.MaxChannelPower[arrayCount] = maxPower.as<uint16_t>(); inverter.MaxChannelPower[arrayCount] = maxPower.as<uint16_t>();
arrayCount++; arrayCount++;