From 088ba58827348101d0b364a4d472eee28912c738 Mon Sep 17 00:00:00 2001 From: Thomas Basler Date: Tue, 13 Sep 2022 22:50:33 +0200 Subject: [PATCH] Mark Single-parameter constructors explicit --- lib/Hoymiles/src/commands/AlarmDataCommand.h | 2 +- lib/Hoymiles/src/commands/CommandAbstract.h | 2 +- lib/Hoymiles/src/commands/DevControlCommand.h | 2 +- lib/Hoymiles/src/commands/DevInfoAllCommand.h | 2 +- lib/Hoymiles/src/commands/DevInfoSampleCommand.h | 2 +- lib/Hoymiles/src/commands/MultiDataCommand.h | 2 +- lib/Hoymiles/src/commands/ParaSetCommand.h | 2 +- lib/Hoymiles/src/commands/RealTimeRunDataCommand.h | 2 +- lib/Hoymiles/src/commands/RequestFrameCommand.h | 2 +- lib/Hoymiles/src/commands/SingleDataCommand.h | 2 +- lib/Hoymiles/src/commands/SystemConfigParaCommand.h | 2 +- lib/Hoymiles/src/inverters/HM_1CH.h | 2 +- lib/Hoymiles/src/inverters/HM_2CH.h | 2 +- lib/Hoymiles/src/inverters/HM_4CH.h | 2 +- lib/Hoymiles/src/inverters/HM_Abstract.h | 2 +- lib/Hoymiles/src/inverters/InverterAbstract.h | 2 +- 16 files changed, 16 insertions(+), 16 deletions(-) diff --git a/lib/Hoymiles/src/commands/AlarmDataCommand.h b/lib/Hoymiles/src/commands/AlarmDataCommand.h index a4015582..5af30ef6 100644 --- a/lib/Hoymiles/src/commands/AlarmDataCommand.h +++ b/lib/Hoymiles/src/commands/AlarmDataCommand.h @@ -4,7 +4,7 @@ class AlarmDataCommand : public MultiDataCommand { public: - AlarmDataCommand(uint64_t target_address = 0, uint64_t router_address = 0, time_t time = 0); + explicit AlarmDataCommand(uint64_t target_address = 0, uint64_t router_address = 0, time_t time = 0); virtual bool handleResponse(InverterAbstract* inverter, fragment_t fragment[], uint8_t max_fragment_id); }; \ No newline at end of file diff --git a/lib/Hoymiles/src/commands/CommandAbstract.h b/lib/Hoymiles/src/commands/CommandAbstract.h index b09177fe..dfcd5224 100644 --- a/lib/Hoymiles/src/commands/CommandAbstract.h +++ b/lib/Hoymiles/src/commands/CommandAbstract.h @@ -10,7 +10,7 @@ class InverterAbstract; class CommandAbstract { public: - CommandAbstract(uint64_t target_address = 0, uint64_t router_address = 0); + explicit CommandAbstract(uint64_t target_address = 0, uint64_t router_address = 0); virtual ~CommandAbstract() {}; template diff --git a/lib/Hoymiles/src/commands/DevControlCommand.h b/lib/Hoymiles/src/commands/DevControlCommand.h index fb2e8f05..44653447 100644 --- a/lib/Hoymiles/src/commands/DevControlCommand.h +++ b/lib/Hoymiles/src/commands/DevControlCommand.h @@ -4,5 +4,5 @@ class DevControlCommand : public CommandAbstract { public: - DevControlCommand(uint64_t target_address = 0, uint64_t router_address = 0); + explicit DevControlCommand(uint64_t target_address = 0, uint64_t router_address = 0); }; \ No newline at end of file diff --git a/lib/Hoymiles/src/commands/DevInfoAllCommand.h b/lib/Hoymiles/src/commands/DevInfoAllCommand.h index 16a0bd9b..964ffaf0 100644 --- a/lib/Hoymiles/src/commands/DevInfoAllCommand.h +++ b/lib/Hoymiles/src/commands/DevInfoAllCommand.h @@ -4,7 +4,7 @@ class DevInfoAllCommand : public MultiDataCommand { public: - DevInfoAllCommand(uint64_t target_address = 0, uint64_t router_address = 0, time_t time = 0); + explicit DevInfoAllCommand(uint64_t target_address = 0, uint64_t router_address = 0, time_t time = 0); virtual bool handleResponse(InverterAbstract* inverter, fragment_t fragment[], uint8_t max_fragment_id); }; \ No newline at end of file diff --git a/lib/Hoymiles/src/commands/DevInfoSampleCommand.h b/lib/Hoymiles/src/commands/DevInfoSampleCommand.h index 5cefd5ef..4bc7aaf9 100644 --- a/lib/Hoymiles/src/commands/DevInfoSampleCommand.h +++ b/lib/Hoymiles/src/commands/DevInfoSampleCommand.h @@ -4,7 +4,7 @@ class DevInfoSampleCommand : public MultiDataCommand { public: - DevInfoSampleCommand(uint64_t target_address = 0, uint64_t router_address = 0, time_t time = 0); + explicit DevInfoSampleCommand(uint64_t target_address = 0, uint64_t router_address = 0, time_t time = 0); virtual bool handleResponse(InverterAbstract* inverter, fragment_t fragment[], uint8_t max_fragment_id); }; \ No newline at end of file diff --git a/lib/Hoymiles/src/commands/MultiDataCommand.h b/lib/Hoymiles/src/commands/MultiDataCommand.h index 46129ebb..511d8c75 100644 --- a/lib/Hoymiles/src/commands/MultiDataCommand.h +++ b/lib/Hoymiles/src/commands/MultiDataCommand.h @@ -6,7 +6,7 @@ class MultiDataCommand : public CommandAbstract { public: - MultiDataCommand(uint64_t target_address = 0, uint64_t router_address = 0, uint8_t data_type = 0, time_t time = 0); + explicit MultiDataCommand(uint64_t target_address = 0, uint64_t router_address = 0, uint8_t data_type = 0, time_t time = 0); void setTime(time_t time); time_t getTime(); diff --git a/lib/Hoymiles/src/commands/ParaSetCommand.h b/lib/Hoymiles/src/commands/ParaSetCommand.h index 926ec30c..caa0a521 100644 --- a/lib/Hoymiles/src/commands/ParaSetCommand.h +++ b/lib/Hoymiles/src/commands/ParaSetCommand.h @@ -4,5 +4,5 @@ class ParaSetCommand : public CommandAbstract { public: - ParaSetCommand(uint64_t target_address = 0, uint64_t router_address = 0); + explicit ParaSetCommand(uint64_t target_address = 0, uint64_t router_address = 0); }; \ No newline at end of file diff --git a/lib/Hoymiles/src/commands/RealTimeRunDataCommand.h b/lib/Hoymiles/src/commands/RealTimeRunDataCommand.h index 09a2bc48..0044ab05 100644 --- a/lib/Hoymiles/src/commands/RealTimeRunDataCommand.h +++ b/lib/Hoymiles/src/commands/RealTimeRunDataCommand.h @@ -4,7 +4,7 @@ class RealTimeRunDataCommand : public MultiDataCommand { public: - RealTimeRunDataCommand(uint64_t target_address = 0, uint64_t router_address = 0, time_t time = 0); + explicit RealTimeRunDataCommand(uint64_t target_address = 0, uint64_t router_address = 0, time_t time = 0); virtual bool handleResponse(InverterAbstract* inverter, fragment_t fragment[], uint8_t max_fragment_id); }; \ No newline at end of file diff --git a/lib/Hoymiles/src/commands/RequestFrameCommand.h b/lib/Hoymiles/src/commands/RequestFrameCommand.h index 4d627679..aebf9483 100644 --- a/lib/Hoymiles/src/commands/RequestFrameCommand.h +++ b/lib/Hoymiles/src/commands/RequestFrameCommand.h @@ -4,7 +4,7 @@ class RequestFrameCommand : public SingleDataCommand { public: - RequestFrameCommand(uint64_t target_address = 0, uint64_t router_address = 0, uint8_t frame_no = 0); + explicit RequestFrameCommand(uint64_t target_address = 0, uint64_t router_address = 0, uint8_t frame_no = 0); void setFrameNo(uint8_t frame_no); uint8_t getFrameNo(); diff --git a/lib/Hoymiles/src/commands/SingleDataCommand.h b/lib/Hoymiles/src/commands/SingleDataCommand.h index aba0fda9..98722518 100644 --- a/lib/Hoymiles/src/commands/SingleDataCommand.h +++ b/lib/Hoymiles/src/commands/SingleDataCommand.h @@ -4,5 +4,5 @@ class SingleDataCommand : public CommandAbstract { public: - SingleDataCommand(uint64_t target_address = 0, uint64_t router_address = 0); + explicit SingleDataCommand(uint64_t target_address = 0, uint64_t router_address = 0); }; \ No newline at end of file diff --git a/lib/Hoymiles/src/commands/SystemConfigParaCommand.h b/lib/Hoymiles/src/commands/SystemConfigParaCommand.h index 003c1d81..805f665e 100644 --- a/lib/Hoymiles/src/commands/SystemConfigParaCommand.h +++ b/lib/Hoymiles/src/commands/SystemConfigParaCommand.h @@ -4,7 +4,7 @@ class SystemConfigParaCommand : public MultiDataCommand { public: - SystemConfigParaCommand(uint64_t target_address = 0, uint64_t router_address = 0, time_t time = 0); + explicit SystemConfigParaCommand(uint64_t target_address = 0, uint64_t router_address = 0, time_t time = 0); virtual bool handleResponse(InverterAbstract* inverter, fragment_t fragment[], uint8_t max_fragment_id); }; \ No newline at end of file diff --git a/lib/Hoymiles/src/inverters/HM_1CH.h b/lib/Hoymiles/src/inverters/HM_1CH.h index 95874652..1f1804f0 100644 --- a/lib/Hoymiles/src/inverters/HM_1CH.h +++ b/lib/Hoymiles/src/inverters/HM_1CH.h @@ -4,7 +4,7 @@ class HM_1CH : public HM_Abstract { public: - HM_1CH(uint64_t serial); + explicit HM_1CH(uint64_t serial); static bool isValidSerial(uint64_t serial); String typeName(); const byteAssign_t* getByteAssignment(); diff --git a/lib/Hoymiles/src/inverters/HM_2CH.h b/lib/Hoymiles/src/inverters/HM_2CH.h index e0562900..69b9c69c 100644 --- a/lib/Hoymiles/src/inverters/HM_2CH.h +++ b/lib/Hoymiles/src/inverters/HM_2CH.h @@ -4,7 +4,7 @@ class HM_2CH : public HM_Abstract { public: - HM_2CH(uint64_t serial); + explicit HM_2CH(uint64_t serial); static bool isValidSerial(uint64_t serial); String typeName(); const byteAssign_t* getByteAssignment(); diff --git a/lib/Hoymiles/src/inverters/HM_4CH.h b/lib/Hoymiles/src/inverters/HM_4CH.h index 9ae30c09..617c839e 100644 --- a/lib/Hoymiles/src/inverters/HM_4CH.h +++ b/lib/Hoymiles/src/inverters/HM_4CH.h @@ -4,7 +4,7 @@ class HM_4CH : public HM_Abstract { public: - HM_4CH(uint64_t serial); + explicit HM_4CH(uint64_t serial); static bool isValidSerial(uint64_t serial); String typeName(); const byteAssign_t* getByteAssignment(); diff --git a/lib/Hoymiles/src/inverters/HM_Abstract.h b/lib/Hoymiles/src/inverters/HM_Abstract.h index b38bad10..36cf462a 100644 --- a/lib/Hoymiles/src/inverters/HM_Abstract.h +++ b/lib/Hoymiles/src/inverters/HM_Abstract.h @@ -4,7 +4,7 @@ class HM_Abstract : public InverterAbstract { public: - HM_Abstract(uint64_t serial); + explicit HM_Abstract(uint64_t serial); bool sendStatsRequest(HoymilesRadio* radio); bool sendAlarmLogRequest(HoymilesRadio* radio); bool sendDevInfoRequest(HoymilesRadio* radio); diff --git a/lib/Hoymiles/src/inverters/InverterAbstract.h b/lib/Hoymiles/src/inverters/InverterAbstract.h index f8afad31..aba60a5b 100644 --- a/lib/Hoymiles/src/inverters/InverterAbstract.h +++ b/lib/Hoymiles/src/inverters/InverterAbstract.h @@ -25,7 +25,7 @@ class CommandAbstract; class InverterAbstract { public: - InverterAbstract(uint64_t serial); + explicit InverterAbstract(uint64_t serial); void init(); uint64_t serial(); void setName(const char* name);