From d52865e54ef59d4a799e2d7fd0b35c3ec5c6a00b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Patrick=20Ha=C3=9Fel?= Date: Mon, 17 Jun 2024 15:25:18 +0200 Subject: [PATCH] code clean --- .../kleinanzeigen/telegram/TelegramService.java | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/src/main/java/de/ph87/kleinanzeigen/telegram/TelegramService.java b/src/main/java/de/ph87/kleinanzeigen/telegram/TelegramService.java index 07b80c0..a3d20f5 100644 --- a/src/main/java/de/ph87/kleinanzeigen/telegram/TelegramService.java +++ b/src/main/java/de/ph87/kleinanzeigen/telegram/TelegramService.java @@ -31,7 +31,6 @@ import java.io.IOException; import java.nio.charset.StandardCharsets; import java.util.ArrayList; import java.util.List; -import java.util.Optional; @Slf4j @Service @@ -71,14 +70,11 @@ public class TelegramService { final List existingMessages = messageService.findAllDtoByOfferDto(offer); final List chats = chatService.findAllEnabled(); for (final ChatDto chat : chats) { - final Optional existing = existingMessages.stream().filter(m -> m.getChat().getId() == chat.getId()).findFirst(); - if (existing.isPresent()) { - log.info("Found existing message: {}", existing); - update(existing.get()); - } else { - log.info("Creating new message for chat={}", chat.getId()); - send(offer, chat); - } + existingMessages + .stream() + .filter(m -> m.getChat().getId() == chat.getId()) + .findFirst() + .ifPresentOrElse(this::update, () -> send(offer, chat)); } } @@ -181,7 +177,7 @@ public class TelegramService { null ); edit.setParseMode("Markdown"); - log.info("Editing Offer: {}", messageDto); + log.info("Editing Message: {}", messageDto); bot.execute(edit); } catch (TelegramApiException | JsonProcessingException e) { if (e.toString().endsWith("Bad Request: message to edit not found")) {