From 6f66cc060c0fa6391d4a1d71eb1ec2ca20e1c836 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Patrick=20Ha=C3=9Fel?= <git@patrick-hassel.de>
Date: Wed, 20 Nov 2024 12:54:12 +0100
Subject: [PATCH] removed Property.valueChanged

---
 src/main/java/de/ph87/home/property/Property.java        | 4 ----
 src/main/java/de/ph87/home/property/PropertyDto.java     | 3 ---
 src/main/java/de/ph87/home/property/PropertyService.java | 3 ---
 3 files changed, 10 deletions(-)

diff --git a/src/main/java/de/ph87/home/property/Property.java b/src/main/java/de/ph87/home/property/Property.java
index 4edb4a9..ca7914b 100644
--- a/src/main/java/de/ph87/home/property/Property.java
+++ b/src/main/java/de/ph87/home/property/Property.java
@@ -6,7 +6,6 @@ import lombok.NonNull;
 import lombok.RequiredArgsConstructor;
 import lombok.ToString;
 
-import java.util.Objects;
 import java.util.function.BiConsumer;
 import java.util.function.Consumer;
 
@@ -51,12 +50,9 @@ public class Property<T> implements IProperty<T> {
   @Nullable
   private State<T> state = null;
 
-  private boolean valueChanged = false;
-
   public void update(@Nullable final State<T> state) {
     this.lastState = this.state;
     this.state = state;
-    this.valueChanged = (lastState == null) == (state == null) && (lastState == null || Objects.equals(lastState.getValue(), state.getValue()));
     this.onStateSet.accept(this);
   }
 
diff --git a/src/main/java/de/ph87/home/property/PropertyDto.java b/src/main/java/de/ph87/home/property/PropertyDto.java
index 4217c2e..0434c15 100644
--- a/src/main/java/de/ph87/home/property/PropertyDto.java
+++ b/src/main/java/de/ph87/home/property/PropertyDto.java
@@ -28,14 +28,11 @@ public class PropertyDto<T> implements IProperty<T> {
   @Nullable
   private final State<T> state;
 
-  private final boolean valueChanged;
-
   public PropertyDto(@NonNull final Property<T> property) {
     this.id = property.getId();
     this.type = property.getType();
     this.state = property.getState();
     this.lastState = property.getLastState();
-    this.valueChanged = property.isValueChanged();
   }
 
 }
diff --git a/src/main/java/de/ph87/home/property/PropertyService.java b/src/main/java/de/ph87/home/property/PropertyService.java
index 979c27c..8f22e16 100644
--- a/src/main/java/de/ph87/home/property/PropertyService.java
+++ b/src/main/java/de/ph87/home/property/PropertyService.java
@@ -96,9 +96,6 @@ public class PropertyService {
   private void onStateSet(@NonNull final Property<?> property) {
     final PropertyDto<?> dto = toDto(property);
     log.debug("Property updated: {}", dto);
-    if (dto.isValueChanged()) {
-      log.info("Property changed: {}", dto);
-    }
     applicationEventPublisher.publishEvent(dto);
   }